Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Create Instance: New widget #5033

Merged
merged 19 commits into from
Nov 3, 2020
Merged

[ENH] Create Instance: New widget #5033

merged 19 commits into from
Nov 3, 2020

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Oct 16, 2020

Issue

Implement a widget for creating an instance, based on input data.

Description of changes
  • new widget
    image
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #5033 into master will increase coverage by 0.07%.
The diff coverage is 96.76%.

@@            Coverage Diff             @@
##           master    #5033      +/-   ##
==========================================
+ Coverage   84.66%   84.73%   +0.07%     
==========================================
  Files         285      286       +1     
  Lines       59557    60042     +485     
==========================================
+ Hits        50423    50879     +456     
- Misses       9134     9163      +29     

@VesnaT VesnaT changed the title [RFC] CreateInstance: New widget [WIP] CreateInstance: New widget Oct 16, 2020
@VesnaT VesnaT changed the title [WIP] CreateInstance: New widget [ENH] CreateInstance: New widget Oct 22, 2020
@VesnaT VesnaT force-pushed the simulator branch 5 times, most recently from 4d3e3bc to ff4d774 Compare October 23, 2020 06:49
@VesnaT VesnaT force-pushed the simulator branch 3 times, most recently from dcc7656 to d40711c Compare October 23, 2020 09:28
@VesnaT VesnaT force-pushed the simulator branch 2 times, most recently from 8dd20c8 to 9ccc0fa Compare October 27, 2020 07:50
@janezd janezd self-assigned this Oct 30, 2020
@lanzagar lanzagar changed the title [ENH] CreateInstance: New widget [ENH] Create Instance: New widget Nov 3, 2020
@lanzagar lanzagar merged commit 81f8364 into biolab:master Nov 3, 2020
@borondics
Copy link
Member

Would it make sense to add the possibility of splitting the dataset according to categorical variables? Right now the category of the output instance can be selected by hand.

@markotoplak
Copy link
Member

@borondics, what do you mean? Is what you say actually connected to this widget (Create instance)? This widget can only create a single output instance, thus I do not understand what you meant by splitting.

@borondics
Copy link
Member

borondics commented Mar 19, 2021

Yes, that way the widget would create one instance for each categorical class based on the class members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants