customizableplot.available_font_families: Fix for non-existent default family #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
non-existent-default-font-family
branch
from
b0e4a4f
to
977eb77
Compare
Codecov Report
@@ Coverage Diff @@
## master #5037 +/- ##
==========================================
+ Coverage 84.66% 84.67% +0.01%
==========================================
Files 285 285
Lines 59509 59557 +48
==========================================
+ Hits 50381 50428 +47
- Misses 9128 9129 +1 |
VesnaT
requested changes
Oct 23, 2020
| top_section = [] | ||
|
|
||
| default_family = default_font_family() | ||
| if default_family in fonts: |
There was a problem hiding this comment.
I think the default_family should be added to the fontList even though not present in QFontDatabase().families(). If not, the combobox may crash when trying to set its text to something missing in its model().
janezd
force-pushed
the
non-existent-default-font-family
branch
from
977eb77
to
86d052b
Compare
VesnaT
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5036.
It seems that the default font doesn't always exist.
Description of changes
Check whether the default font family exists. If not, just return a sorted list of families, without pushing the default to the top.
Also: tests for
available_font_family.Includes