Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] SQL: Fix the issue with database collation setting when retrieving column values #5089

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

PrimozGodec
Copy link
Contributor

Issue

The database can have different collation settings (how to compare characters in the group by, distinct, ...). It has an impact on values we get when we retrieve all distinct values from column to create a discrete variable. If a collation is Latin it ignores utf8 characters, it can even be case insensitive. When creating variable we still want to have all possible values in the column since later when we retrieve actual data for a table (SELECT * FROM Table) we get values as they are (collation does not have an effect).

Description of changes

This PR implements a workaround for GROUP BY in cases when we want all values to create a variable.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #5089 (bcdb587) into master (81ccf30) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5089      +/-   ##
==========================================
+ Coverage   84.65%   84.74%   +0.08%     
==========================================
  Files         285      286       +1     
  Lines       59541    60043     +502     
==========================================
+ Hits        50406    50884     +478     
- Misses       9135     9159      +24     

@PrimozGodec PrimozGodec force-pushed the sql-create-variable-fix branch from fc15679 to bcdb587 Compare November 19, 2020 14:38
@lanzagar lanzagar merged commit 1277566 into biolab:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants