[FIX] Distance Matrix: Fix freeze with large selections #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplement QHeaderView.paintSection to avoid expensive calls to QItemSelectionModel.isRowSelected.
Codecov Report
@@ Coverage Diff @@
## master #5176 +/- ##
==========================================
+ Coverage 84.79% 84.88% +0.09%
==========================================
Files 286 289 +3
Lines 60189 60376 +187
==========================================
+ Hits 51036 51249 +213
+ Misses 9153 9127 -26 |
ales-erjavec
changed the title
ales-erjavec
force-pushed
the
distance-matrix-selection-model
branch
from
e6710c0
to
5f3202a
Compare
Extracted from owtable, slightly generalized.
ales-erjavec
force-pushed
the
distance-matrix-selection-model
branch
from
5f3202a
to
16ebd0f
Compare
Operate on selection ranges not on indices
ales-erjavec
force-pushed
the
distance-matrix-selection-model
branch
from
16ebd0f
to
1b95643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Selecting all items (ctrl+a) in Distance Matrix freezes on large inputs (~4000x4000).
Builds on top of gh-5164
Description of changes
Optimize SymmetricSelectionModel to operate on selection ranges not individual indices.
Refactor/extract BlockSelectionModel and SymmetricSelectionModel into utility module.
Includes