Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owdataset: Do not capture self in closure #5198

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

ales-erjavec
Copy link
Contributor

Issue

OWDataSets captures self in a closure executing in a worker thread.

See: biolab/orange3-single-cell#381 (comment)

Description of changes

Parameterize and move the functions out of the class.

Includes
  • Code changes
  • Tests
  • Documentation

Parameterize and move the functions out of the class.
@ales-erjavec ales-erjavec force-pushed the datasets-no-self-capture branch from 73310de to db6e84f Compare January 21, 2021 14:21
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #5198 (db6e84f) into master (c25f185) will increase coverage by 0.23%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #5198      +/-   ##
==========================================
+ Coverage   84.82%   85.06%   +0.23%     
==========================================
  Files         288      298      +10     
  Lines       60358    60816     +458     
==========================================
+ Hits        51197    51731     +534     
+ Misses       9161     9085      -76     

@PrimozGodec PrimozGodec merged commit 3015722 into biolab:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants