Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix performance regression in scatterplot #5206

Merged

Conversation

markotoplak
Copy link
Member

Issue

PR #5038 introduced jittering suspension with selection. It introduced a performance regression, because it needlessly updated point positions while the selection was being performed. For example, with 10000 data points, selection was lagging noticeably.

Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak markotoplak changed the title Fix scatterplot selection performance [FIX] Fix performance regression in scatterplot Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #5206 (9c3a4b5) into master (a6e34b2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5206      +/-   ##
==========================================
+ Coverage   85.13%   85.14%   +0.01%     
==========================================
  Files         299      299              
  Lines       60876    60882       +6     
==========================================
+ Hits        51824    51837      +13     
+ Misses       9052     9045       -7     

PR biolab#5038 introduced jittering suspension with selection. It introduced a
performance regression, because it needlessly updated point positions
while the selection was being performed. For example, with 10000 data
points, selection was lagging noticeably.
@markotoplak markotoplak force-pushed the fix-scatterplot-selection-performance branch from fb44859 to 7f7e301 Compare January 22, 2021 15:50
@janezd janezd merged commit ef5a39c into biolab:master Jan 22, 2021
@markotoplak markotoplak deleted the fix-scatterplot-selection-performance branch November 25, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants