Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Pivot: Display time variable in time format #5212

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Jan 27, 2021

Issue

Fixes #5180 for TimeVariable.

Description of changes

Display TimeVariable values in time format.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #5212 (510aa22) into master (0d6da92) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5212   +/-   ##
=======================================
  Coverage   85.17%   85.18%           
=======================================
  Files         299      299           
  Lines       60888    60906   +18     
=======================================
+ Hits        51864    51884   +20     
+ Misses       9024     9022    -2     

@ajdapretnar
Copy link
Contributor

I'm getting the below error then opening Pivot Table. Looking at the code it doesn't make sense, but probably I am missing something. 🤷

----------------------------- TypeError Exception -----------------------------
TypeError: sizeHint() missing 1 required positional argument: 'self'
-------------------------------------------------------------------------------

@VesnaT
Copy link
Contributor Author

VesnaT commented Jan 28, 2021

Fixed.

@ajdapretnar ajdapretnar merged commit fc77d66 into biolab:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pivot table does not show the expected count and value
2 participants