[FIX] Create Class: multiple patterns for a class value #5283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
createclass-repeated
branch
from
b52f416
to
b96da96
Compare
Codecov Report
@@ Coverage Diff @@
## master #5283 +/- ##
=======================================
Coverage 85.21% 85.21%
=======================================
Files 300 300
Lines 61009 61022 +13
=======================================
+ Hits 51987 52000 +13
Misses 9022 9022 |
|
@markotoplak, can you rebase, please? (Conflict in tests.) |
Before, repeated output class values created a DiscreteVariable with repeated values, which introduced problems later on. This PR ensures that all values of the output DiscreteVariable are unique. A single value can be shared by multiple match patterns.
markotoplak
force-pushed
the
createclass-repeated
branch
from
b96da96
to
30a3c7c
Compare
|
@janezd, I just rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Repeated output class values created a DiscreteVariable with repeated values, which introduced problems later on. This PR fixes Quasars/orange-spectroscopy#521.
Description of changes
This PR ensures that all values of the output DiscreteVariable are unique.
Allowing multiple match patterns for a single value seems like a useful feature (we get something similar to OR conditions). So I decided to support it rather than blocking it on input.
Patterns are still being matched in the same order as before, so this PR should not change any behavior that was valid before the fix. Also, the order of output values is kept.
Includes