[FIX] UrlReader: Support urls with special characters #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VesnaT
force-pushed
the
url_reader_special_chars
branch
from
3cc5a35
to
62a7605
Compare
Codecov Report
@@ Coverage Diff @@
## master #5412 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 303 303
Lines 62155 62156 +1
=======================================
+ Hits 53688 53690 +2
+ Misses 8467 8466 -1 |
3 tasks
This was referenced Jan 11, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
OWFilewidget can't read files with special characters in their urls.Description of changes
Fix UrlReader:
urllib.parse.quoteto encode the urlIncludes