[FIX] listfilter: Bypass QListView.dropEvent #5477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Qt >= 5.15.2 QListView.dropEvent depends on private state tracking that is setup in startDrag. Since startDrag is overridden here and does not dispatch to the base implementation, this causes items loss when performing internal move.
Codecov Report
@@ Coverage Diff @@
## master #5477 +/- ##
=======================================
Coverage 86.35% 86.36%
=======================================
Files 304 304
Lines 61652 61654 +2
=======================================
+ Hits 53240 53247 +7
+ Misses 8412 8407 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-5471
On Qt >= 5.15.2 QListView.dropEvent depends on private state tracking
that is setup in startDrag. Since startDrag is overridden here and does
not dispatch to the base implementation, this causes items loss when
performing internal move.
Description of changes
Bypass QListView.dropEvent
Includes