-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] PCA: Output variance of components #5513
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5513 +/- ##
==========================================
- Coverage 86.38% 86.36% -0.02%
==========================================
Files 304 304
Lines 61753 61848 +95
==========================================
+ Hits 53344 53414 +70
- Misses 8409 8434 +25 |
I love how this widget got from basic to jacked 💪 in no time. 😆 As for the label, if points for labeling are <= to the height of the font, then plot the higher one above, not below the point it labels? (stupid suggestion probably, just throwing ideas out there) |
Ha! Labels are |
66c326e
to
736ef6f
Compare
3cd179c
to
a2afed5
Compare
I rebased this and am (for now) only merging the first commit. The others are backed-up at https://github.com/markotoplak/orange3/tree/pca-show-variance-backup In between, a group from Mannheim, particularly @Les-Simon, proposed some changes to the PCA (and other widgets): https://github.com/Charisma-Mannheim/OrangeExtension. They tend to work with PCA a lot, much more than we do. We should consider their suggestions before adding additional complexity to the widget. |
Issue
Fixes two thirds of #5468.
To test before biolab/orange-widget-base#162 is merged, change
to
Description of changes
Variances are added as attributes of variables, and as extra meta columns in the components output.
The table with variances is shown in control area and can be used as the third mean to select components. Clicking a row selects all components up to that row. (Selecting arbitrary rows is not possible: the widget's code does not support it; interactions the other two controls would be weird; this is not typical for PCA; for atypical uses, there's Select Rows; no a/b testing of this feature will be done, thanks for not asking :).
The third point in the issue was reporting variance on new data. This can be added to the table, but I'd suggest this to be a separate issue/PR.
Includes