Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] config: sort example workflows #5600

Merged
merged 1 commit into from
Sep 24, 2021
Merged

[ENH] config: sort example workflows #5600

merged 1 commit into from
Sep 24, 2021

Conversation

mw25
Copy link
Contributor

@mw25 mw25 commented Sep 21, 2021

Issue

Suggestion for biolab/orange-canvas-core#203

Description of changes

The tutorial entrypoints are sorted by name to make the order of the example workflows adjustable.
The entry point name for the default workflows starts with '000' so that they are at the beginning.
Unless the entrypoint name of another add-on starts with e.g. '!'
This way, example workflows could also be placed at the very beginning.
Normally the entrypoints are called 'exampletutorials' and are appended to the defaults. With a prefix ('100', '200') the order between different add-ons can be controlled.

The sorting could also be moved to orange-canvas-core/orangecanvas/application/examples.py, because the add-on-internal sorting is already there.

Includes
  • Code changes
  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #5600 (f71c93e) into master (2146396) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5600   +/-   ##
=======================================
  Coverage   85.93%   85.94%           
=======================================
  Files         313      313           
  Lines       65466    65466           
=======================================
+ Hits        56261    56262    +1     
+ Misses       9205     9204    -1     

@ales-erjavec ales-erjavec changed the title config: sort example workflows [ENH] config: sort example workflows Sep 24, 2021
@ales-erjavec ales-erjavec merged commit 03e8ada into biolab:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants