Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table_from_frames: fix indices parsing #5620

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Oct 1, 2021

Issue

table_from_frames vas not working since index selection was failing #5615

Description of changes

Fixing index retention from the Pandas data frame. Now numbers xxx from indices with format _oxxx are kept. Indexes must match across all three dataframes.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the fix-table_from_frames branch 2 times, most recently from f957732 to 73c31c2 Compare October 19, 2021 12:17
@PrimozGodec PrimozGodec force-pushed the fix-table_from_frames branch from 73c31c2 to 72c5b24 Compare October 19, 2021 12:41
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #5620 (72c5b24) into master (8ed85c8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5620      +/-   ##
==========================================
+ Coverage   85.97%   86.00%   +0.03%     
==========================================
  Files         313      313              
  Lines       65649    65649              
==========================================
+ Hits        56444    56464      +20     
+ Misses       9205     9185      -20     

@VesnaT VesnaT merged commit 7356c5d into biolab:master Oct 25, 2021
markotoplak pushed a commit to markotoplak/orange3 that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants