[FIX] Projections: Fix color density for continuous color palettes #5665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5665 +/- ##
=======================================
Coverage 86.01% 86.02%
=======================================
Files 315 315
Lines 65948 65950 +2
=======================================
+ Hits 56726 56731 +5
+ Misses 9222 9219 -3 |
markotoplak
pushed a commit
to markotoplak/orange3
that referenced
this pull request
Oct 27, 2021
[FIX] Projections: Fix color density for continuous color palettes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5638.
The obvious symptom was that colors density was sometimes not shown. In reality, even when shown, it was sometimes incorrect.
The code ignores the points that are not colored because the corresponding "color index" exceeds the number of availiable colors. This filter should only be applied when coloring according to discrete palettes, not continuous ones.
Description of changes
Check that colors are discrete before filtering them.
Includes