Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Group by: compute mode when all values in group nan #5763

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Jan 5, 2022

Issue

Fixes #5738

Description of changes
  • Fix mode to work in cases when all values in the group are nan
  • test case with only nan values in the group
  • additionally: use gui.deferred for autocoomit
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #5763 (8929ba8) into master (06d7f24) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5763      +/-   ##
==========================================
- Coverage   86.16%   86.15%   -0.01%     
==========================================
  Files         315      315              
  Lines       66195    66197       +2     
==========================================
- Hits        57035    57034       -1     
- Misses       9160     9163       +3     

@janezd janezd self-assigned this Jan 7, 2022
@janezd
Copy link
Contributor

janezd commented Jan 7, 2022

The reason why I haven't migrated commit in this widget is, obviously, that it was still not finished by the time I made that PR. :)

@janezd janezd merged commit 5d83588 into biolab:master Jan 7, 2022
@PrimozGodec PrimozGodec deleted the fix-groupby branch January 7, 2022 12:53
markotoplak pushed a commit to markotoplak/orange3 that referenced this pull request Jan 7, 2022
[FIX] Group by: compute mode when all values in group nan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group By: uninformative error message
2 participants