Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Update (and test) minimum dependencies #5781

Merged
merged 16 commits into from
Jan 14, 2022

Conversation

markotoplak
Copy link
Member

@markotoplak markotoplak commented Jan 13, 2022

Issue

Our dependency list is stale. Occasionally tests fail in my valid but old python environment.

Description of changes

I added testing with oldest dependencies.

There are still requirements without specified versions. I left them as they were, for now, for better clarity of the changes in this PR (and due to some laziness). These should get defined in another PR.

@markotoplak markotoplak changed the title [CI [WIP][CI] Test oldest dependencies Jan 13, 2022
@markotoplak markotoplak force-pushed the oldest branch 2 times, most recently from 64eefa6 to 92fd3b6 Compare January 13, 2022 12:18
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #5781 (5a0c8db) into master (aa9877e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5781   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files         316      316           
  Lines       66382    66382           
=======================================
  Hits        57168    57168           
  Misses       9214     9214           

@markotoplak markotoplak force-pushed the oldest branch 3 times, most recently from d8ee242 to d770920 Compare January 13, 2022 18:07
@markotoplak markotoplak changed the title [WIP][CI] Test oldest dependencies [WIP][FIX] Update (and test) minimum dependencies Jan 13, 2022
@markotoplak markotoplak changed the title [WIP][FIX] Update (and test) minimum dependencies [FIX] Update (and test) minimum dependencies Jan 13, 2022
@markotoplak
Copy link
Member Author

markotoplak commented Jan 13, 2022

@JakaKokosar, do you know of a better way for testing this?

@markotoplak markotoplak marked this pull request as draft January 13, 2022 18:58
@markotoplak markotoplak force-pushed the oldest branch 2 times, most recently from 3debdca to 69a3da2 Compare January 13, 2022 20:40
@markotoplak markotoplak marked this pull request as ready for review January 13, 2022 21:11
@markotoplak
Copy link
Member Author

The last failed test is not connected to this PR.

@JakaKokosar
Copy link
Member

@JakaKokosar, do you know of a better way for testing this?

This is how we do it in add-ons. LGTM :)

@JakaKokosar JakaKokosar merged commit e4ea535 into biolab:master Jan 14, 2022
@markotoplak markotoplak deleted the oldest branch February 28, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants