[FIX] Table: from_file/from_url remove type conversion #5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
fix-table-lock
branch
3 times, most recently
from
387ab35
to
cf80042
Compare
Codecov Report
@@ Coverage Diff @@
## master #5812 +/- ##
=======================================
Coverage 86.13% 86.13%
=======================================
Files 316 316
Lines 66388 66384 -4
=======================================
- Hits 57182 57179 -3
+ Misses 9206 9205 -1 |
PrimozGodec
force-pushed
the
fix-table-lock
branch
from
cf80042
to
a716c12
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When from_file/from_url is called on from table derived class, the type is changed after the reading (with calling table constructor) and so the view is made -- which is not expected by
from_fileDescription of changes
In discussion with @markotoplak we decided to remove the type conversion since it is causing issues (also destroys the type when for example Corpus is pickled). Classes that are derived from Table can handle the conversion themselves.
Includes