Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] File: remove some resizing limits #5815

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

markotoplak
Copy link
Member

Issue

Long combo box contents prevented widget resize. Offenders:

  • File
  • Sheet
  • Reader
Description of changes

Used Expanding size-policy instead of MinimumExpanding and set the minimum size to something small but potentially usable. These should keep default appearance as before, observing Qt's size hints, but allows making the widget smaller.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #5815 (4ba218d) into master (dfd2734) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5815      +/-   ##
==========================================
- Coverage   86.14%   86.13%   -0.01%     
==========================================
  Files         316      316              
  Lines       66388    66391       +3     
==========================================
- Hits        57187    57186       -1     
- Misses       9201     9205       +4     

@ajdapretnar ajdapretnar merged commit ef36780 into biolab:master Jan 31, 2022
@markotoplak markotoplak deleted the fix-owfile-min-size branch February 28, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants