Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Orange.data.Table: deprecated is_view and is_copy #5913

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

noahnovsak
Copy link
Contributor

Issue

fixes #5878

Description of changes

deprecated is_view and is_copy as requested

Includes
  • Code changes
  • Tests

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #5913 (f5cae57) into master (93cf05f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f5cae57 differs from pull request most recent head 6052878. Consider uploading reports for the commit 6052878 to get more accurate results

@@           Coverage Diff           @@
##           master    #5913   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files         315      315           
  Lines       66833    66886   +53     
=======================================
+ Hits        57666    57712   +46     
- Misses       9167     9174    +7     

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@markotoplak
Copy link
Member

@needNewUsername, thanks. The deprecations should also somehow notify the user what to do instead (I think this is a parameter to the decorator). Ideally, they would also specify when does the support stop.

And finally, make a time bomb that notifies us when to remove the code, like test_check_learner_adequacy_deprecated in #5848.

@markotoplak
Copy link
Member

Thanks! Could you now rebase into a single commit?

@markotoplak markotoplak changed the title [FIX] Orange.data.Table: deprecated is_view and is_copy Orange.data.Table: deprecated is_view and is_copy Mar 25, 2022
@markotoplak markotoplak changed the title Orange.data.Table: deprecated is_view and is_copy [FIX] Orange.data.Table: deprecated is_view and is_copy Mar 25, 2022
@markotoplak markotoplak merged commit 92066e2 into biolab:master Mar 25, 2022
@noahnovsak noahnovsak deleted the deprecate_view_copy branch March 28, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orange.data.Table's is_view and is_copy do not work for sparse matrices: deprecate them
3 participants