Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Feature Constructor cast function is not picklable #6002

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Jun 3, 2022

Issue

Feature Constructor can construct compute_value which are not picklable (defined in local function scope):

Fixes gh-5918

Description of changes
  • Make the cast function passed to FeatureFunc picklable.
  • Some refactoring of classes from oweditdomain.
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec changed the title [FIX] Feature Constructor cast [FIX] Feature Constructor cast function is not picklable Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #6002 (e33b38f) into master (04c0e73) will increase coverage by 0.03%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master    #6002      +/-   ##
==========================================
+ Coverage   86.59%   86.63%   +0.03%     
==========================================
  Files         315      315              
  Lines       67317    67560     +243     
==========================================
+ Hits        58295    58531     +236     
- Misses       9022     9029       +7     

@ales-erjavec ales-erjavec marked this pull request as ready for review August 1, 2022 10:10
@markotoplak markotoplak merged commit 9d73b8e into biolab:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color: error when deleting the widget or opening/closing a workflow with this widget
2 participants