Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Embedders - fix proxies, default on http, tests #6028

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

PrimozGodec
Copy link
Contributor

Issue
  • Function that sets proxies for embedders used https proxy for http
  • When no scheme provided, scheme should default to http
Description of changes

Fix and error and default on HTTP when no scheme is provided with URL. The same default is used with other libraries, such as requests.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #6028 (7f83008) into master (fabacdf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6028   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files         315      315           
  Lines       67308    67317    +9     
=======================================
+ Hits        58282    58291    +9     
  Misses       9026     9026           

@PrimozGodec PrimozGodec force-pushed the change-proxy-behaviour branch from 5653e55 to 9a46bd3 Compare June 17, 2022 10:05
@PrimozGodec PrimozGodec force-pushed the change-proxy-behaviour branch from 9a46bd3 to 7f83008 Compare June 17, 2022 11:18
@lanzagar lanzagar merged commit 6d95493 into biolab:master Jun 17, 2022
@PrimozGodec PrimozGodec deleted the change-proxy-behaviour branch June 17, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants