Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate Columns: Add additional options for selection #6056

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Jul 10, 2022

Issue

Fixes #5643.

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #6056 (6282b98) into master (0524aa9) will increase coverage by 0.01%.
The diff coverage is 99.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6056      +/-   ##
==========================================
+ Coverage   86.65%   86.66%   +0.01%     
==========================================
  Files         315      315              
  Lines       67623    67715      +92     
==========================================
+ Hits        58597    58688      +91     
- Misses       9026     9027       +1     

@markotoplak
Copy link
Member

markotoplak commented Sep 29, 2022

Seems fine. There is some seemingly inconsistent behaviour with the Features input:

  1. with 2 numerical features, the widget goes into the features input mode and disables the rest.
  2. with 1 numerical and 1 categorical feature, the widget goes into the features input mode, disables the rest, and shows a warning,
  3. with 2 categorical features, the widget DOES NOT go into the features input mode, but still shows a warning.

With (3) I'd expect that the widget goes into the features input mode (because of the input), and an error was shown. Or perhaps easier to program, the same warning + an error because no features can be aggregated.

@janezd janezd self-assigned this Oct 14, 2022
@janezd janezd removed their assignment Oct 14, 2022
@markotoplak markotoplak merged commit 4788c6e into biolab:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregate Columns default selection
2 participants