[FIX] Handle timezones in Edit Domain #6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
changed the title
|
/rebase |
biolab-helper
force-pushed
the
edit-domain-fix-dt
branch
from
0e924a6
to
c3d2994
Compare
PrimozGodec
force-pushed
the
edit-domain-fix-dt
branch
6 times, most recently
from
04b0d8b
to
0f91912
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6123 +/- ##
=======================================
Coverage 86.46% 86.46%
=======================================
Files 315 315
Lines 67645 67670 +25
=======================================
+ Hits 58488 58512 +24
- Misses 9157 9158 +1 |
PrimozGodec
force-pushed
the
edit-domain-fix-dt
branch
4 times, most recently
from
5f008d9
to
44c7547
Compare
PrimozGodec
changed the title
PrimozGodec
force-pushed
the
edit-domain-fix-dt
branch
3 times, most recently
from
d4060c1
to
b5d9ca1
Compare
PrimozGodec
force-pushed
the
edit-domain-fix-dt
branch
from
b5d9ca1
to
7b40090
Compare
janezd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Transforming to Time variable fails when timezone is in strings
Description of changes
Correctly handle timezones in data time
Additionally: First I planned to raise the Pandas version to 1.4 since this version already supports subtracting different timezones. It was impossible since Pandas>=1.4 does not support Python 3.7 anymore, so building documentation fails (by readthedcos) since they build documentation on Python 3.7. Setting different versions of python for rtd is supported by the config file, but it cannot be used with multiple subprojects. We cannot raise the Pandas' version until they start supporting config files for subprojects or building on python 3.8.
Includes