Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Preprocess: Fix reporting for remove sparse and impute #6212

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Nov 19, 2022

Issue

Report for this widget showed class names instead of parameters.

Description of changes

Classes RemoveSparseEditor and ImputeEditor missed __repr__, which is used by report to show parameters.

Includes
  • Code changes
  • Tests

@janezd janezd force-pushed the preprocess-missing-reprs branch 3 times, most recently from 9b6899e to 9a6b9fc Compare November 19, 2022 17:18
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #6212 (0d0cb53) into master (0d3e3ee) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6212   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files         316      316           
  Lines       68021    68031   +10     
=======================================
+ Hits        58948    58958   +10     
  Misses       9073     9073           

@janezd janezd force-pushed the preprocess-missing-reprs branch 2 times, most recently from c5960c0 to 3bdc218 Compare November 19, 2022 20:10
@janezd janezd force-pushed the preprocess-missing-reprs branch from 3bdc218 to 0d0cb53 Compare November 19, 2022 20:24
@janezd janezd assigned janezd and VesnaT and unassigned janezd Nov 25, 2022
@VesnaT VesnaT merged commit 7243c9f into biolab:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants