[FIX] Color: fix coloring of computed (processed) variables #6261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
changed the title
markotoplak
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6261 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 316 316
Lines 68120 68120
=======================================
+ Hits 59064 59065 +1
+ Misses 9056 9055 -1 |
Variables stored in context settings were reused when constructing new domains. Therefore, there were problems if only their compute_values changed because the old context (matching names and values) still matched. After this fix the variable descriptors on the input are always used when creating colored variables instead of the ones stored in the context. Also, compute_values do not need to be stored in settings and are therefore removed.
markotoplak
force-pushed
the
fix-color-compute-value
branch
from
c06940b to
aaeac3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes Quasars/orange-spectroscopy#652
The Color widget currently saves
AttrDescin contexts. The problem is thatAttrDesccontains a variable. Because the contexts only match by names (and values for discrete features) the saved variables get colored instead of the ones on the input.Description of changes
After this fix, the variable descriptors on the input are always used when creating colored variables instead of the ones stored in the context.
Also, compute_values do not need to be stored in settings (within
AttrDesc) and are therefore removed.Includes