[FIX] Table.from_table works correctly with boolean indices #6278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimize_indices now converts boolean indices into integer indices which are easier to work with (and are assumed in the rest of the code)
lanzagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Table.from_tabledoes not work correctly with boolean indices, butfrom_table_rowsdoes. See the added test.Description of changes
Much of the code in
from_tableexpects either slices or integer row indices, so boolean indices are converted to that.The second last commit is a minor refactor of handling of
Wandidsinfrom_tableso that it becomes equivalent to thefrom_table_rowsimplementation. Why did we handle them differently?from_tablehad some code from 2015 at that so I though it might not be needed anymore.The last commit splits off two well-defined operations from
from_tableso that the code is a bit cleaner.Includes