Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] listfilter: Fix dragDropActionDidComplete signal type #6292

Merged

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Jan 12, 2023

Issue

Fixes: #6287

In PyQt6 Qt.DropAction is not an integer.

Description of changes
  • Change dragDropActionDidComplete signal type (in PyQt6 Qt.DropAction is not an integer)
Includes
  • Code changes
  • Tests
  • Documentation

In PyQt6 Qt.DropAction is not an integer.
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #6292 (30f2d22) into master (d56940c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6292      +/-   ##
==========================================
+ Coverage   86.88%   86.91%   +0.03%     
==========================================
  Files         318      318              
  Lines       68491    68491              
==========================================
+ Hits        59507    59529      +22     
+ Misses       8984     8962      -22     

@JakaKokosar
Copy link
Member

This looks good to me! Thanks :)

@JakaKokosar JakaKokosar merged commit 30cc856 into biolab:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select Column does not send data on completed drag and drop action
2 participants