Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Concatenate - preserve table names when compute value ignored #6331

Merged

Conversation

PrimozGodec
Copy link
Contributor

Issue

Coconcate widget does not preserve table names when compute value is ignored, so unknown appears in the Source ID column instead of the correct name.

Description of changes

Preserve table name also when ignore compute value is ticked.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #6331 (84acb93) into master (10bb2b1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6331   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files         316      316           
  Lines       68053    68054    +1     
=======================================
+ Hits        59534    59539    +5     
+ Misses       8519     8515    -4     

@markotoplak
Copy link
Member

Fixes #6332.

@markotoplak markotoplak merged commit cdf6672 into biolab:master Feb 7, 2023
@PrimozGodec PrimozGodec deleted the concatenate-preserve-table-name branch February 7, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants