Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Data Table: Subset input #6405

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Apr 7, 2023

Issue

Closes: #6315

Add Data Subset input and indicate the subset in the table

Screenshot 2023-04-07 at 15 14 53

Uses opacity of non subset data to emphasize subset to match other visualization widgets, and also adds an indicator to the row header (I don't like either).

Description of changes

Add subset input

Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec changed the title [ENH] Data Table: Subset input [RFC][ENH] Data Table: Subset input Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #6405 (e379aa8) into master (74f83d4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6405      +/-   ##
==========================================
+ Coverage   87.62%   87.65%   +0.02%     
==========================================
  Files         321      321              
  Lines       69056    69149      +93     
==========================================
+ Hits        60513    60612      +99     
+ Misses       8543     8537       -6     

@ales-erjavec ales-erjavec force-pushed the owtable-subset-input branch from 846f347 to 20dec52 Compare April 12, 2023 10:38
@ales-erjavec ales-erjavec changed the title [RFC][ENH] Data Table: Subset input [ENH] Data Table: Subset input Apr 13, 2023
@ales-erjavec ales-erjavec marked this pull request as ready for review April 13, 2023 14:21
@janezd janezd added this to the 3.35.0 milestone Apr 14, 2023
@VesnaT
Copy link
Contributor

VesnaT commented Apr 14, 2023

/rebase

@VesnaT
Copy link
Contributor

VesnaT commented Apr 14, 2023

It looks good to me.

One thing, that could also be handled is to retain the selection when connecting/disconnecting the subset.
Beside that, resending the output on connecting/disconnecting the subset seems unnecessary.

@ales-erjavec ales-erjavec force-pushed the owtable-subset-input branch from 20dec52 to d096f17 Compare April 14, 2023 12:50
@ales-erjavec ales-erjavec force-pushed the owtable-subset-input branch from d096f17 to e379aa8 Compare April 14, 2023 13:00
@VesnaT VesnaT merged commit f993763 into biolab:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Table: single tab, bug fixes and subset input
3 participants