Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Edit Domain no longer forgets its settings #6415

Merged
merged 2 commits into from
May 5, 2023

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Apr 15, 2023

Issue

Fixes #6414, if I'm guessing correctly.

None of context settings were variables, so all contexts always matched. While contexts piled up, the widget most likely picked the most recent context and used whatever was applicable.

Description of changes

Instead of context setting with changes for particular domain, the widget now uses a schema-only settings with hints that are matched to any applicable variables. To prevent bloating, up to 1000 hints are kept (unless the current domain contains more).

Includes
  • Code changes
  • Tests

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #6415 (c5fa7b7) into master (81ef8cb) will increase coverage by 0.00%.
The diff coverage is 95.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6415   +/-   ##
=======================================
  Coverage   87.62%   87.63%           
=======================================
  Files         321      321           
  Lines       69056    69084   +28     
=======================================
+ Hits        60513    60540   +27     
- Misses       8543     8544    +1     

@janezd janezd force-pushed the edit-domain-noncontext branch 12 times, most recently from 2699d6b to c2926df Compare April 15, 2023 21:05
@janezd janezd force-pushed the edit-domain-noncontext branch from c2926df to d59c045 Compare April 16, 2023 09:12
@janezd janezd force-pushed the edit-domain-noncontext branch from 3cf75c6 to c5fa7b7 Compare April 16, 2023 18:26
@janezd janezd changed the title Edit Domain: Use schema-only settings instead of context settings [FIX] Edit Domain should no longer have problems with remembering its settings Apr 21, 2023
@janezd janezd changed the title [FIX] Edit Domain should no longer have problems with remembering its settings [FIX] Edit Domain no longer forgets its settings Apr 21, 2023
@markotoplak markotoplak merged commit 0684aa4 into biolab:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Domain resets when reopening orange
2 participants