Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ListView - empty variable when all values unselected #6441

Merged
merged 1 commit into from
May 18, 2023

Conversation

PrimozGodec
Copy link
Contributor

Issue

When using ExtendedSelection or MultiSelection and all values are unselected, the setting attribute still keeps the old selection.

Description of changes

Set the setting attribute to the empty list when all values are unselected.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the fix-list-view-selection branch from d08d4df to 0a6165d Compare May 8, 2023 14:24
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #6441 (0a6165d) into master (e35d172) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6441   +/-   ##
=======================================
  Coverage   87.66%   87.66%           
=======================================
  Files         321      321           
  Lines       69203    69203           
=======================================
+ Hits        60665    60666    +1     
+ Misses       8538     8537    -1     

@PrimozGodec PrimozGodec marked this pull request as ready for review May 8, 2023 14:42
@janezd janezd self-assigned this May 12, 2023
@janezd janezd merged commit 2d2e297 into biolab:master May 18, 2023
@PrimozGodec PrimozGodec deleted the fix-list-view-selection branch February 16, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants