Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] PCA widget runs a separate thread #6528

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

markotoplak
Copy link
Member

@markotoplak markotoplak commented Aug 11, 2023

Issue

For larger data PCA takes longer. Moving computation to a separate thread allows canvas to still be responsive.

Description of changes

The first two commits only refactor the widget to lose some attributes.

This PR only improves the responsiveness of canvas. I did not find any easy ways to interrupt PCA so that is not done here.
Edit: I added a commit that allows for cancelling within preprocessing. Code was stolen from owoutliers and the current implementation in Learner.

Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak
Copy link
Member Author

/rebase

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #6528 (e94858f) into master (94b28dc) will decrease coverage by 0.01%.
The diff coverage is 93.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6528      +/-   ##
==========================================
- Coverage   87.68%   87.68%   -0.01%     
==========================================
  Files         321      321              
  Lines       69371    69405      +34     
==========================================
+ Hits        60830    60858      +28     
- Misses       8541     8547       +6     

@markotoplak markotoplak force-pushed the concurrent-pca branch 2 times, most recently from 3962110 to e607e09 Compare August 11, 2023 10:25
@markotoplak markotoplak merged commit 9eb6490 into biolab:master Aug 11, 2023
@markotoplak markotoplak deleted the concurrent-pca branch November 6, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants