Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Scatter Plot - Handle input features that are hidden in data #6531

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

PrimozGodec
Copy link
Contributor

Issue

Connected to #6367
When some features are hidden in the data, and those features are present on Scatter Plot's feature input widget fails.

Description of changes

Handle describe scenario and do not plot anyting

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #6531 (84eafd2) into master (9eb6490) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6531   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files         321      321           
  Lines       69405    69409    +4     
=======================================
+ Hits        60858    60864    +6     
+ Misses       8547     8545    -2     

@janezd janezd self-assigned this Aug 17, 2023
if all(attr in self.xy_model for attr in self.attribute_selection_list):
self.attr_x, self.attr_y = self.attribute_selection_list
else:
self.attr_x, self.attr_y = None, None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be better to set attr_x and attr_y to the first two variables in the model, as default? Or did I miss something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, I wanted to explicitly show that the user provided the wrong features on the input (so nothing is plotted). Do you think it is better to plot the first two features and ignore the features input in this case?

@janezd janezd added this to the 3.36.0 milestone Sep 1, 2023
@janezd janezd merged commit 972405f into biolab:master Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants