Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Adapt tests to pandas 2.1 and fix deprecations #6560

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Aug 31, 2023

Description of changes
  • CI - Stop testing Python 3.8 since it isn't recommended to support it anymore, according to NEP 29. Pandas, Numpy, and Scipy dropped support already (after reading skip in the second point of this PR, it is unnecessary to drop those tests anymore, but I would go further with this anyway).
  • Re-add skip to pandas test that was removed as part of [FIX] Adapt to newly released pandas 2.1 #6559 (since, at some point, we will probably run the oldest supported workflow with Pandas 2.0.*). It was updating the skipp that was still present and a minor update of the test.
  • Handle some deprecations in the Pandas module (is_categorical_dtype and setting value by index without iloc).
  • Reupdate import from [FIX] Adapt to newly released pandas 2.1 #6559
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec marked this pull request as ready for review August 31, 2023 07:42
@PrimozGodec PrimozGodec changed the title [FIX] Adapt tests to pandas 2.1 [FIX] Adapt tests to pandas 2.1 and fix deprecations Aug 31, 2023
@markotoplak markotoplak merged commit 4ddff41 into biolab:master Aug 31, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants