[FIX] Fix impute.Model for derived domains #6668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
fix-impute-model
branch
2 times, most recently
from
53429a2
to
53bbd08
Compare
janezd
reviewed
Dec 7, 2023
The compute_value was missing transformation into the variable space it was working upon.
markotoplak
force-pushed
the
fix-impute-model
branch
from
53bbd08
to
1d80036
Compare
|
The fix does not prevent the Prediction error message, it only changes it.
|
|
@VesnaT, thanks. I removed the "fixes" statement in the issue description, but think that this is still a step forward and that this PR should be merged. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6668 +/- ##
==========================================
- Coverage 88.10% 88.10% -0.01%
==========================================
Files 321 321
Lines 69946 69950 +4
==========================================
+ Hits 61628 61629 +1
- Misses 8318 8321 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Found at #6644, but per @VesnaT's comment does not fix it because another check fails.Fixes #6644 (after @VesnaT's commit).
Description of changes
The compute_value was missing transformation into the variable space it was working upon.
Thanks to @VesnaT for providing minimum code that reproduced the error.
Includes