-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix failing tests on Python 3.11.8 on Windows #6737
Conversation
4a265d0
to
3bb11f6
Compare
3bb11f6
to
7a6cbe7
Compare
It seems that closing is not working in openpyxl as it worked in older versions of Python. I reported it: https://foss.heptapod.net/openpyxl/openpyxl/-/issues/2149 |
02a9dea
to
8f7aa0b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6737 +/- ##
==========================================
- Coverage 88.13% 88.10% -0.04%
==========================================
Files 322 323 +1
Lines 70589 70670 +81
==========================================
+ Hits 62216 62264 +48
- Misses 8373 8406 +33 |
23b5fee
to
8b892ab
Compare
/rebase |
5393b08
to
24a5198
Compare
Here, you monkey patch ExcelReader. Does this code need to be in If possible, I'd also rather import it where the reader is implemented (of course, it that does not work, forget it). |
a2f8d2d
to
6026fe9
Compare
@markotoplak, I changed it such that it is patched on the place it is used. :) |
Issue
Recently, some tests started to fail on Windows. The issue is that Actions upgraded the Python 3.11 version to 3.11.8, which was released two weeks ago. The issue is caused by openpyxl and is fixed here: https://foss.heptapod.net/openpyxl/openpyxl/-/merge_requests/436.
Description of changes
Since it seems it will take a long for openpyxl to make a release I am making a temporary (ugly) patch here. This method is a copy of the fixed method from openpyxl).
Includes