Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix failing tests on Python 3.11.8 on Windows #6737

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Feb 16, 2024

Issue

Recently, some tests started to fail on Windows. The issue is that Actions upgraded the Python 3.11 version to 3.11.8, which was released two weeks ago. The issue is caused by openpyxl and is fixed here: https://foss.heptapod.net/openpyxl/openpyxl/-/merge_requests/436.

Description of changes

Since it seems it will take a long for openpyxl to make a release I am making a temporary (ugly) patch here. This method is a copy of the fixed method from openpyxl).

Includes
  • Code changes
  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2024

CLA assistant check
All committers have signed the CLA.

@PrimozGodec
Copy link
Contributor Author

It seems that closing is not working in openpyxl as it worked in older versions of Python. I reported it: https://foss.heptapod.net/openpyxl/openpyxl/-/issues/2149
Will try to continue debugging next week.

@PrimozGodec PrimozGodec force-pushed the fix-tests branch 2 times, most recently from 02a9dea to 8f7aa0b Compare February 29, 2024 15:52
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #6737 (c2b75b7) into master (ba951fa) will decrease coverage by 0.04%.
The diff coverage is 58.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6737      +/-   ##
==========================================
- Coverage   88.13%   88.10%   -0.04%     
==========================================
  Files         322      323       +1     
  Lines       70589    70670      +81     
==========================================
+ Hits        62216    62264      +48     
- Misses       8373     8406      +33     

@PrimozGodec PrimozGodec force-pushed the fix-tests branch 3 times, most recently from 23b5fee to 8b892ab Compare February 29, 2024 16:31
@PrimozGodec
Copy link
Contributor Author

/rebase

@PrimozGodec PrimozGodec force-pushed the fix-tests branch 2 times, most recently from 5393b08 to 24a5198 Compare February 29, 2024 16:44
@PrimozGodec PrimozGodec marked this pull request as ready for review February 29, 2024 16:47
@markotoplak
Copy link
Member

Here, you monkey patch ExcelReader. Does this code need to be in Orange.__init__? I know it will be removed, but I'd at least put this into a new file. Then, I'd import it with try catch.

If possible, I'd also rather import it where the reader is implemented (of course, it that does not work, forget it).

@PrimozGodec PrimozGodec force-pushed the fix-tests branch 2 times, most recently from a2f8d2d to 6026fe9 Compare March 1, 2024 11:20
@PrimozGodec
Copy link
Contributor Author

@markotoplak, I changed it such that it is patched on the place it is used. :)

@markotoplak markotoplak merged commit bc3d58f into biolab:master Mar 8, 2024
23 of 27 checks passed
ales-erjavec added a commit to ales-erjavec/orange3 that referenced this pull request May 31, 2024
This reverts commit bc3d58f, reversing
changes made to 6c99b83.
@ales-erjavec ales-erjavec mentioned this pull request May 31, 2024
3 tasks
@PrimozGodec PrimozGodec deleted the fix-tests branch May 31, 2024 08:39
markotoplak added a commit that referenced this pull request May 31, 2024
stuart-cls pushed a commit to stuart-cls/orange3 that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants