Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Minor fixes to reenable falling CI #6751

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Mar 1, 2024

Description of changes
  • Cryptography package requires pip>19.3 to install Linux wheels. Otherwise, it wants to build, which fails. https://cryptography.io/en/latest/installation/. I increased the minimum pip version to >=19.3.
  • Pandas will make Copy-on-write default in 3.0.0 realise which also changes constructors behaviour to copy all arrays. I set copy=False in the OrangeDataFrame constructor to keep the current behaviour also in Pandas 3.0.0.
  • Numpy will soon release version 2, which will break Orange since it requires all packages to be built against version 2.0.0 and probably all dependent packages will not be ready. Also, Orange may not be ready. Pin numpy<2.
  • When the oldest test was not working, CSV Import got a new test, test_long_data, which seems to fail on Pandas 1.* since it raises TypeError instead of expected ValueError (it doesn't happen in Pandas 2.*). From caution, I added a check for the TypeError instead of raising the required Pandas to >=2.0.0.
Includes
  • Code changes
  • Tests
  • Documentation

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Merging #6751 (3972575) into master (ba951fa) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6751      +/-   ##
==========================================
- Coverage   88.13%   88.13%   -0.01%     
==========================================
  Files         322      322              
  Lines       70589    70590       +1     
==========================================
  Hits        62216    62216              
- Misses       8373     8374       +1     

@PrimozGodec PrimozGodec marked this pull request as ready for review March 1, 2024 16:18
@PrimozGodec PrimozGodec changed the title Fix failing tests [FIX] Minor fixes to reenable falling CI Mar 1, 2024
@PrimozGodec PrimozGodec requested a review from markotoplak March 5, 2024 11:54
@markotoplak markotoplak merged commit e2684f1 into biolab:master Mar 11, 2024
24 of 27 checks passed
@PrimozGodec PrimozGodec deleted the fix-ci2 branch March 14, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants