Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Edit Domain: Partial restore state on categories mismatch #6776

Merged
merged 4 commits into from
May 24, 2024

Conversation

ales-erjavec
Copy link
Contributor

Issue

Fixes: gh-6660

Description of changes
  • Ignore categories when exact match for a variable is not found in the stored settings (i.e. match by name and type only).
  • If a stored transform is a CategoriesMapping transform that does not match the input, then it is dropped and a warning is shown.
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the oweditdomain-restore-state branch from 9e593fe to 1770def Compare April 2, 2024 07:17
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (91b7fcb) to head (62e1f31).
Report is 40 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6776   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         327      327           
  Lines       71318    71346   +28     
=======================================
+ Hits        62926    62953   +27     
- Misses       8392     8393    +1     

@janezd janezd self-assigned this Apr 12, 2024
Ignore categories when exact match for a variable is not found
in the stored settings (i.e. match by name and type only).

If a stored transform is a `CategoriesMapping` transform that
does not match the input, then it is dropped and a warning is
shown.
@markotoplak markotoplak force-pushed the oweditdomain-restore-state branch from 5315d49 to 62e1f31 Compare May 24, 2024 12:10
@markotoplak markotoplak merged commit bb1009b into biolab:master May 24, 2024
21 of 30 checks passed
@ales-erjavec ales-erjavec deleted the oweditdomain-restore-state branch May 27, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit domain forgets settings for categorical variables when values change in any way
3 participants