Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Logistic regression: fix penalty argument for no regularization #6886

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Sep 6, 2024

Issue

Fixes #6885.

As of 1.3.2, Scikit used to accept 'none' as penalty. In 1.5.1 it expects None.

I unsuccessfully tried to find where, when and why it changed, but it doesn't really matter, I guess.

Description of changes

Replace 'none' with None.

Includes
  • Code changes
  • Tests

@janezd janezd mentioned this pull request Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base (6c742f7) to head (f9f4e59).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6886      +/-   ##
==========================================
- Coverage   88.26%   88.26%   -0.01%     
==========================================
  Files         326      326              
  Lines       71184    71184              
==========================================
- Hits        62834    62833       -1     
- Misses       8350     8351       +1     

@markotoplak markotoplak changed the title Logistic regression: Fix penalty argument [FIX] Logistic regression: fix for no regularization Oct 2, 2024
@markotoplak markotoplak changed the title [FIX] Logistic regression: fix for no regularization [FIX] Logistic regression: fix penalty argument for no regularization Oct 2, 2024
@markotoplak markotoplak merged commit 60a2f61 into biolab:master Oct 2, 2024
19 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logistic Regression
2 participants