[FIX] Calibrated Learner: Prevent in place modification of base learner #6917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6917 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 326 326
Lines 71971 71970 -1
=======================================
+ Hits 63624 63626 +2
+ Misses 8347 8344 -3 |
janezd
reviewed
Oct 23, 2024
…earner The instance's name is modified in place after. Replace IdentityWrapper (which did not work) with copy.deepcopy of the instance.
ales-erjavec
force-pushed
the
fixes/owcalibratedlearner-base-learner-modify
branch
from
9aa3e34
to
4e7e541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #6915
Description of changes
base_learnerinstance fromcreate_learnerIncludes