Handle GPI label merge for geneontology/go-releases#50 #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dustine32 By my read, this is a specific |
kltm
approved these changes
Oct 4, 2023
|
If #648 (comment), feel free to merge on your schedule. |
|
@kltm Yup, that block is there for any future field-merge logic with label being the only current use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For geneontology/go-releases#50.
This fleshes out the
collections.BioEntities.merge()function to better handle labels when some are blank. The entity label should only be overwritten if the new label is non-blank.In our actual use case here:
BioEntitiesfirst.BioEntitiesobject.BioEntitiesare merged into the existing GAF-derived GPIBioEntitiesensuring that, if the canonical GPI has a blank symbol, it does not clobber the existing non-blank symbol.