Reverting FAIL to OKAY since obsolete terms have no namespace #649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change corresponds to geneontology/go-site#2002. Slight correction of initial PR #646.
This fixes a bug introduced with #646 that was failing all obsoleted terms in rule 61 because their ontology node did not have a
namespace
key:ontobio/ontobio/io/qc.py
Line 907 in 6a9924a
An example obsoleted term is GO:1902361. The failed GO rule test example is here: https://github.com/geneontology/go-site/blob/master/metadata/rules/gorule-0000020.md
I added a test for this (within
ontobio
!!) under rule 61 and confirmed that thego-site
test suite (really just a wrapper aroundontobio
'svalidate.py rule
command) runs w/o error.