Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For #1553 #667

Merged
merged 1 commit into from
Feb 22, 2024
Merged

For #1553 #667

merged 1 commit into from
Feb 22, 2024

Conversation

mugitty
Copy link
Collaborator

@mugitty mugitty commented Feb 22, 2024

Updated for deprecated gorule

@dustine32
Copy link
Collaborator

Tying this to geneontology/go-site#1553.

dustine32
dustine32 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight-forward removal of GoRule code is good with me!

@mugitty Just curious. Does this automatically remove GO rule 57 from the assigned-by-gorule-report.html or is this controlled in go-site?

@mugitty mugitty mentioned this pull request Feb 22, 2024
Closed
@mugitty
Copy link
Collaborator Author

mugitty commented Feb 22, 2024

@dustine32 , go-site does not control it. Once ontobio stops outputting information about the rule, the reports will not output information about them.

@mugitty mugitty merged commit 95707dd into master Feb 22, 2024
5 checks passed
@mugitty mugitty deleted the go-site-1553-gorule-0000057-has-been-deprecated branch May 6, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustine32 dustine32 dustine32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mugitty @dustine32