Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For #2210 #679

Merged
merged 1 commit into from
Jul 19, 2024
Merged

For #2210 #679

merged 1 commit into from
Jul 19, 2024

Conversation

mugitty
Copy link
Collaborator

@mugitty mugitty commented Jul 19, 2024

No description provided.

@mugitty mugitty requested a review from dustine32 July 19, 2024 01:32
dustine32
dustine32 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mugitty Moving from regex.match to regex.fullmatch. I assume this is intended to be more strict to catch some invalid values that were previously getting through the .match function?

@dustine32
Copy link
Collaborator

Linking to geneontology/go-site#2210

@mugitty
Copy link
Collaborator Author

mugitty commented Jul 19, 2024

@mugitty Moving from regex.match to regex.fullmatch. I assume this is intended to be more strict to catch some invalid values that were previously getting through the .match function?
Yes @dustine32 this will make it more restrictive since the pattern should match the entire curie string

@mugitty mugitty merged commit 5f865b1 into master Jul 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustine32 dustine32 dustine32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mugitty @dustine32