Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #36

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Refactor code #36

merged 8 commits into from
Oct 5, 2023

Conversation

vedran-kasalica
Copy link
Member

@vedran-kasalica vedran-kasalica commented Sep 22, 2023

Progress:

  • Complete removing load_binary from metadata class (make use of functions uniform accross package, i.e. no methods on classes)
  • Expose functions at top-level of package
  • Somehting else?

Closes #35

@vedran-kasalica
Copy link
Member Author

I finished the following tasks:

  • removed load_binary from tsdf class
  • fixed read_binary.load_binary_from_metadata

@kretep, you can continue doing the remaining tasks as agreed

@vedran-kasalica vedran-kasalica removed the request for review from kretep September 22, 2023 10:54
@kretep
Copy link
Member

kretep commented Oct 2, 2023

This now also addresses #24

@kretep
Copy link
Member

kretep commented Oct 2, 2023

The functions are now exposed at the top-level of the package, although the modules are still in there too (not sure how to hide them...)

@kretep kretep marked this pull request as ready for review October 2, 2023 08:49
@kretep
Copy link
Member

kretep commented Oct 2, 2023

To be complete: while restructuring the package, I also refactored the tests. The reference to the test data directory was not working properly; now using a plugin for that.

Also simplified and split up the usage documentation (notebooks)

Copy link
Member Author

@vedran-kasalica vedran-kasalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, the tests and the notebooks were nicely refactored .

@vedran-kasalica
Copy link
Member Author

Closes #24

@kretep kretep merged commit da15acb into main Oct 5, 2023
1 check passed
@kretep kretep deleted the refactor branch October 5, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor some code
2 participants