-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code #36
Refactor code #36
Conversation
I finished the following tasks:
@kretep, you can continue doing the remaining tasks as agreed |
Use pytest-datadir to pass data dir to tests Remove use of unittest
This now also addresses #24 |
The functions are now exposed at the top-level of the package, although the modules are still in there too (not sure how to hide them...) |
To be complete: while restructuring the package, I also refactored the tests. The reference to the test data directory was not working properly; now using a plugin for that. Also simplified and split up the usage documentation (notebooks) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, the tests and the notebooks were nicely refactored .
Closes #24 |
Progress:
Closes #35