Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce type checking with pytype #68

Merged
merged 10 commits into from
Mar 11, 2024
Merged

Introduce type checking with pytype #68

merged 10 commits into from
Mar 11, 2024

Conversation

vedran-kasalica
Copy link
Member

  • Include pytype in the dev dependencies
  • Fix existing typing issues
  • Add a GitHub action to test typing on depyment

@vedran-kasalica vedran-kasalica changed the title Introduce typechecking Introduce type checking with pytype Mar 7, 2024
@vedran-kasalica vedran-kasalica added the enhancement New feature or request label Mar 7, 2024
@vedran-kasalica vedran-kasalica marked this pull request as ready for review March 8, 2024 19:20
@vedran-kasalica vedran-kasalica linked an issue Mar 8, 2024 that may be closed by this pull request
kretep
kretep previously approved these changes Mar 11, 2024
@vedran-kasalica vedran-kasalica dismissed kretep’s stale review March 11, 2024 14:02

The merge-base changed after approval.

kretep
kretep previously approved these changes Mar 11, 2024
@vedran-kasalica vedran-kasalica dismissed kretep’s stale review March 11, 2024 14:14

The merge-base changed after approval.

@vedran-kasalica
Copy link
Member Author

@kretep I think you will have to re-approve the PR.

kretep
kretep previously approved these changes Mar 11, 2024
@vedran-kasalica vedran-kasalica dismissed kretep’s stale review March 11, 2024 14:35

The merge-base changed after approval.

@vedran-kasalica vedran-kasalica merged commit 00a07a3 into main Mar 11, 2024
2 checks passed
@vedran-kasalica vedran-kasalica deleted the typechecking branch March 11, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement type checking
2 participants