refactor(analyzer): severity in metadata

crates/biome_analyze/src/rule.rs

@@ -8,11 +8,11 @@ use biome_console::fmt::Display;
 use biome_console::{markup, MarkupBuf};
 use biome_diagnostics::advice::CodeSuggestionAdvice;
 use biome_diagnostics::location::AsSpan;
-use biome_diagnostics::Applicability;
 use biome_diagnostics::{
     Advices, Category, Diagnostic, DiagnosticTags, Location, LogCategory, MessageAndDescription,
     Visit,
 };
+use biome_diagnostics::{Applicability, Severity};
 use biome_rowan::{AstNode, BatchMutation, BatchMutationExt, Language, TextRange};
 use std::borrow::Cow;
 use std::cmp::Ordering;
@@ -41,6 +41,8 @@ pub struct RuleMetadata {
     pub sources: &'static [RuleSource],
     /// The source kind of the rule
     pub source_kind: Option<RuleSourceKind>,
+    /// The default severity of the rule
+    pub severity: Severity,
 }
 
 #[derive(Clone, Copy, Debug, Default, Eq, PartialEq)]
@@ -328,6 +330,7 @@ impl RuleMetadata {
             fix_kind: FixKind::None,
             sources: &[],
             source_kind: None,
+            severity: Severity::Information,
         }
     }
 
@@ -364,6 +367,11 @@ impl RuleMetadata {
         self
     }
 
+    pub const fn severity(mut self, severity: Severity) -> Self {
+        self.severity = severity;
+        self
+    }
+
     pub fn applicability(&self) -> Applicability {
         self.fix_kind
             .try_into()

crates/biome_css_analyze/src/lint/a11y/use_generic_font_names.rs

@@ -6,6 +6,7 @@ use biome_css_syntax::{
     AnyCssAtRule, AnyCssGenericComponentValue, AnyCssValue, CssAtRule,
     CssGenericComponentValueList, CssGenericProperty, CssSyntaxKind,
 };
+use biome_diagnostics::Severity;
 use biome_rowan::{AstNode, SyntaxNodeCast, TextRange};
 use biome_string_case::StrLikeExtension;
 
@@ -65,6 +66,7 @@ declare_lint_rule! {
         name: "useGenericFontNames",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("font-family-no-missing-generic-family-keyword")],
     }
 }

crates/biome_css_analyze/src/lint/correctness/no_invalid_direction_in_linear_gradient.rs

@@ -3,6 +3,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::{CssFunction, CssParameter};
+use biome_diagnostics::Severity;
 use biome_rowan::AstNode;
 use biome_rowan::AstSeparatedList;
 use biome_string_case::StrLikeExtension;
@@ -47,6 +48,7 @@ declare_lint_rule! {
         name: "noInvalidDirectionInLinearGradient",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("function-linear-gradient-no-nonstandard-direction")],
     }
 }

crates/biome_css_analyze/src/lint/correctness/no_invalid_grid_areas.rs

@@ -3,6 +3,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::CssDeclarationOrRuleList;
+use biome_diagnostics::Severity;
 use biome_rowan::{TextRange, TokenText};
 
 use rustc_hash::FxHashSet;
@@ -53,6 +54,7 @@ declare_lint_rule! {
         name: "noInvalidGridAreas",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("named-grid-areas-no-invalid")],
     }
 }

crates/biome_css_analyze/src/lint/correctness/no_invalid_position_at_import_rule.rs

@@ -3,6 +3,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::{AnyCssRule, CssRuleList};
+use biome_diagnostics::Severity;
 use biome_rowan::{AstNode, TextRange};
 
 declare_lint_rule! {
@@ -31,6 +32,7 @@ declare_lint_rule! {
         name: "noInvalidPositionAtImportRule",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("no-invalid-position-at-import-rule")],
     }
 }

crates/biome_css_analyze/src/lint/correctness/no_unknown_function.rs

@@ -3,6 +3,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::CssFunction;
+use biome_diagnostics::Severity;
 use biome_rowan::{AstNode, TextRange};
 
 use crate::utils::{is_custom_function, is_function_keyword};
@@ -36,6 +37,7 @@ declare_lint_rule! {
         name: "noUnknownFunction",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("function-no-unknown")],
     }
 }

crates/biome_css_analyze/src/lint/correctness/no_unknown_media_feature_name.rs

@@ -8,6 +8,7 @@ use biome_css_syntax::{
     AnyCssMediaTypeQuery, AnyCssQueryFeature, CssMediaAndCondition, CssMediaConditionQuery,
     CssMediaOrCondition, CssMediaQueryList,
 };
+use biome_diagnostics::Severity;
 use biome_rowan::AstNode;
 
 use crate::utils::is_media_feature_name;
@@ -71,6 +72,7 @@ declare_lint_rule! {
         name: "noUnknownMediaFeatureName",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("media-feature-name-no-unknown")],
     }
 }

crates/biome_css_analyze/src/lint/correctness/no_unknown_property.rs

@@ -3,6 +3,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::CssGenericProperty;
+use biome_diagnostics::Severity;
 use biome_rowan::{AstNode, TextRange};
 use biome_string_case::StrLikeExtension;
 
@@ -61,6 +62,7 @@ declare_lint_rule! {
         name: "noUnknownProperty",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("property-no-unknown")],
     }
 }

crates/biome_css_analyze/src/lint/correctness/no_unknown_unit.rs

@@ -5,6 +5,7 @@ use biome_console::markup;
 use biome_css_syntax::{
     AnyCssDimension, CssFunction, CssGenericProperty, CssQueryFeaturePlain, CssSyntaxKind,
 };
+use biome_diagnostics::Severity;
 use biome_rowan::{SyntaxNodeCast, TextRange};
 use biome_string_case::StrLikeExtension;
 
@@ -64,6 +65,7 @@ declare_lint_rule! {
         name: "noUnknownUnit",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("unit-no-unknown")],
     }
 }

crates/biome_css_analyze/src/lint/correctness/no_unmatchable_anb_selector.rs

@@ -5,6 +5,7 @@ use biome_console::markup;
 use biome_css_syntax::{
     AnyCssPseudoClassNth, CssPseudoClassFunctionSelectorList, CssPseudoClassNthSelector,
 };
+use biome_diagnostics::Severity;
 use biome_rowan::{AstNode, SyntaxNodeCast};
 
 declare_lint_rule! {
@@ -57,6 +58,7 @@ declare_lint_rule! {
         name: "noUnmatchableAnbSelector",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("selector-anb-no-unmatchable")],
     }
 }

crates/biome_css_analyze/src/lint/nursery/no_descending_specificity.rs

@@ -4,6 +4,7 @@ use biome_analyze::{context::RuleContext, declare_lint_rule, Rule, RuleDiagnosti
 use biome_console::markup;
 use biome_css_semantic::model::{Rule as CssSemanticRule, RuleId, SemanticModel, Specificity};
 use biome_css_syntax::{AnyCssSelector, CssRoot};
+use biome_diagnostics::Severity;
 use biome_rowan::TextRange;
 
 use biome_rowan::AstNode;
@@ -76,6 +77,7 @@ declare_lint_rule! {
         name: "noDescendingSpecificity",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("no-descending-specificity")],
     }
 }

crates/biome_css_analyze/src/lint/nursery/no_duplicate_custom_properties.rs

@@ -3,6 +3,7 @@ use std::collections::hash_map::Entry;
 use biome_analyze::{context::RuleContext, declare_lint_rule, Rule, RuleDiagnostic, RuleSource};
 use biome_console::markup;
 use biome_css_syntax::CssDeclarationOrRuleList;
+use biome_diagnostics::Severity;
 use biome_rowan::{AstNode, TextRange};
 use rustc_hash::FxHashMap;
 
@@ -40,6 +41,7 @@ declare_lint_rule! {
         name: "noDuplicateCustomProperties",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("declaration-block-no-duplicate-custom-properties")],
     }
 }

crates/biome_css_analyze/src/lint/nursery/no_duplicate_properties.rs

@@ -3,6 +3,7 @@ use std::{borrow::Cow, collections::hash_map::Entry};
 use biome_analyze::{context::RuleContext, declare_lint_rule, Rule, RuleDiagnostic, RuleSource};
 use biome_console::markup;
 use biome_css_syntax::CssDeclarationOrRuleList;
+use biome_diagnostics::Severity;
 use biome_rowan::{AstNode, TextRange};
 use biome_string_case::StrOnlyExtension;
 use rustc_hash::FxHashMap;
@@ -39,6 +40,7 @@ declare_lint_rule! {
         name: "noDuplicateProperties",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("declaration-block-no-duplicate-properties")],
     }
 }

crates/biome_css_analyze/src/lint/nursery/no_missing_var_function.rs

@@ -1,6 +1,7 @@
 use biome_analyze::{context::RuleContext, declare_lint_rule, Rule, RuleDiagnostic, RuleSource};
 use biome_console::markup;
 use biome_css_syntax::{AnyCssProperty, CssDashedIdentifier, CssDeclaration, CssSyntaxKind};
+use biome_diagnostics::Severity;
 use biome_rowan::AstNode;
 
 use crate::services::semantic::Semantic;
@@ -117,6 +118,7 @@ declare_lint_rule! {
         name: "noMissingVarFunction",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("custom-property-no-missing-var-function")],
     }
 }

crates/biome_css_analyze/src/lint/nursery/no_unknown_pseudo_class.rs

@@ -13,6 +13,7 @@ use biome_css_syntax::{
     CssPseudoClassFunctionSelector, CssPseudoClassFunctionSelectorList,
     CssPseudoClassFunctionValueList, CssPseudoClassIdentifier, CssPseudoElementSelector,
 };
+use biome_diagnostics::Severity;
 use biome_rowan::{declare_node_union, AstNode, TextRange};
 use biome_string_case::StrLikeExtension;
 
@@ -62,6 +63,7 @@ declare_lint_rule! {
         name: "noUnknownPseudoClass",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("selector-pseudo-class-no-unknown")],
     }
 }

crates/biome_css_analyze/src/lint/nursery/no_unknown_pseudo_element.rs

@@ -3,6 +3,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::{AnyCssPseudoElement, CssPseudoElementSelector};
+use biome_diagnostics::Severity;
 use biome_rowan::AstNode;
 use biome_string_case::StrLikeExtension;
 
@@ -54,6 +55,7 @@ declare_lint_rule! {
         name: "noUnknownPseudoElement",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("selector-pseudo-element-no-unknown")],
     }
 }

crates/biome_css_analyze/src/lint/nursery/no_unknown_type_selector.rs

@@ -3,6 +3,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::CssTypeSelector;
+use biome_diagnostics::Severity;
 use biome_rowan::AstNode;
 
 use crate::utils::is_known_type_selector;
@@ -54,6 +55,7 @@ declare_lint_rule! {
         name: "noUnknownTypeSelector",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("selector-type-no-unknown")],
     }
 }

crates/biome_css_analyze/src/lint/suspicious/no_duplicate_at_import_rules.rs

@@ -5,6 +5,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::{AnyCssAtRule, AnyCssRule, CssImportAtRule, CssRuleList};
+use biome_diagnostics::Severity;
 use biome_rowan::AstNode;
 use biome_string_case::StrOnlyExtension;
 
@@ -51,6 +52,7 @@ declare_lint_rule! {
         name: "noDuplicateAtImportRules",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("no-duplicate-at-import-rules")],
     }
 }

crates/biome_css_analyze/src/lint/suspicious/no_duplicate_font_names.rs

@@ -5,6 +5,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::{AnyCssGenericComponentValue, AnyCssValue, CssGenericProperty};
+use biome_diagnostics::Severity;
 use biome_rowan::{AstNode, TextRange};
 use biome_string_case::StrLikeExtension;
 
@@ -48,6 +49,7 @@ declare_lint_rule! {
         name: "noDuplicateFontNames",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("font-family-no-duplicate-names")],
     }
 }

crates/biome_css_analyze/src/lint/suspicious/no_duplicate_selectors_keyframe_block.rs

@@ -5,6 +5,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::{AnyCssKeyframesItem, AnyCssKeyframesSelector, CssKeyframesBlock};
+use biome_diagnostics::Severity;
 use biome_rowan::AstNode;
 use biome_string_case::StrLikeExtension;
 
@@ -42,6 +43,7 @@ declare_lint_rule! {
         name: "noDuplicateSelectorsKeyframeBlock",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources:&[RuleSource::Stylelint("keyframe-block-no-duplicate-selectors")],
     }
 }

crates/biome_css_analyze/src/lint/suspicious/no_empty_block.rs

@@ -3,6 +3,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::stmt_ext::CssBlockLike;
+use biome_diagnostics::Severity;
 use biome_rowan::AstNode;
 
 declare_lint_rule! {
@@ -47,6 +48,7 @@ declare_lint_rule! {
         name: "noEmptyBlock",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("block-no-empty")],
     }
 }

crates/biome_css_analyze/src/lint/suspicious/no_important_in_keyframe.rs

@@ -5,6 +5,7 @@ use biome_console::markup;
 use biome_css_syntax::{
     AnyCssDeclarationBlock, AnyCssKeyframesItem, CssDeclarationImportant, CssKeyframesBlock,
 };
+use biome_diagnostics::Severity;
 use biome_rowan::AstNode;
 
 declare_lint_rule! {
@@ -45,6 +46,7 @@ declare_lint_rule! {
         name: "noImportantInKeyframe",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources:&[RuleSource::Stylelint("keyframe-declaration-no-important")],
     }
 }

crates/biome_css_analyze/src/lint/suspicious/no_shorthand_property_overrides.rs

@@ -5,6 +5,7 @@ use biome_analyze::{
 };
 use biome_console::markup;
 use biome_css_syntax::{AnyCssDeclarationName, CssGenericProperty, CssLanguage, CssSyntaxKind};
+use biome_diagnostics::Severity;
 use biome_rowan::{AstNode, Language, SyntaxNode, TextRange, WalkEvent};
 
 fn remove_vendor_prefix<'a>(prop: &'a str, prefix: &'a str) -> &'a str {
@@ -72,6 +73,7 @@ declare_lint_rule! {
         name: "noShorthandPropertyOverrides",
         language: "css",
         recommended: true,
+        severity: Severity::Error,
         sources: &[RuleSource::Stylelint("declaration-block-no-shorthand-property-overrides")],
     }
 }