fix(noUnknownPseudoClass): not error for pseudo class after webkit sc…

…rollbar element (#4543)
biomejs · Nov 15, 2024 · e936902 · e936902
1 parent 63b213b
commit e936902
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -45,10 +45,23 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 ### Bug fixes
 
 - Fix [#4121](https://github.com/biomejs/biome/issues/4326), don't ident a CSS selector when has leading comments. Contributed by @fireairforce
+
 - Fix [#4334](https://github.com/biomejs/biome/issues/4334), don't insert trailing comma on type import statement. Contributed by @fireairforce
+
 - Fix [#3229](https://github.com/biomejs/biome/issues/3229), where Biome wasn't idempotent when block comments were placed inside compound selectors. Contributed by @ematipico
+
 - Fix [#4026](https://github.com/biomejs/biome/issues/4026), don't move comments in `grid-template`. Contributed by @fireairforce
 
+- Fix [#4533](URL_ADDRESS.com/biomejs/biome/issues/4533), don't throw error when pseudeo class after a webkit scrollbar pseudeo element.
+
+  The follow code will not report:
+
+  ```css
+  ::-webkit-scrollbar-thumb:hover {}
+  ```
+
+  Contributed by @fireairforce
+
 ### JavaScript APIs
 
 ### Linter

diff --git a/crates/biome_css_analyze/src/lint/nursery/no_unknown_pseudo_class.rs b/crates/biome_css_analyze/src/lint/nursery/no_unknown_pseudo_class.rs
@@ -176,6 +176,7 @@ impl Rule for NoUnknownPseudoClass {
             PseudoClassType::PagePseudoClass => is_page_pseudo_class(lower_name),
             PseudoClassType::WebkitScrollbarPseudoClass => {
                 WEBKIT_SCROLLBAR_PSEUDO_CLASSES.contains(&lower_name)
+                    || is_known_pseudo_class(lower_name)
             }
             PseudoClassType::Other => {
                 is_custom_selector(lower_name)

diff --git a/crates/biome_css_analyze/tests/specs/nursery/noUnknownPseudoClass/valid.css b/crates/biome_css_analyze/tests/specs/nursery/noUnknownPseudoClass/valid.css
@@ -34,4 +34,5 @@ html { --custom-property-set: {} }
 a:defined { }
 *:is(*) { }
 :popover-open {}
-:seeking, :stalled, :buffering, :volume-locked, :muted {}
+:seeking, :stalled, :buffering, :volume-locked, :muted {}
+::-webkit-scrollbar-button:hover {}
diff --git a/crates/biome_css_analyze/tests/specs/nursery/noUnknownPseudoClass/valid.css.snap b/crates/biome_css_analyze/tests/specs/nursery/noUnknownPseudoClass/valid.css.snap
@@ -41,4 +41,5 @@ a:defined { }
 *:is(*) { }
 :popover-open {}
 :seeking, :stalled, :buffering, :volume-locked, :muted {}
+::-webkit-scrollbar-button:hover {}
 ```