feat(grit): add more formatting nodes #4515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds many more formatting for many more nodes for the grit language. I also fixed some existing issues around how lists were formatted.
FYI, I used
TrailingSeparator::Omit
for all lists, which removes the last trailing separator in case it's present. We can revisit the logic later on.I removed the node
GritPatternArgList
because it wasn't needed. I updated the code accordingly.Inside
GritBubble
, I renamedvariables
inscope
; considering that the relative node is calledGritBubbleScope
, it felt adequate.Test Plan
Added new tests and updated the existing ones.