Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_cli): enable .editorconfig by default #5127

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fireairforce
Copy link
Member

Summary

closes: #4812

I set config https://biomejs.dev/reference/configuration/#formatteruseeditorconfig default value as true.

Test Plan

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project labels Feb 15, 2025
@arendjr
Copy link
Contributor

arendjr commented Feb 16, 2025

Double-checking: has the functionality been implemented to prevent loading.editorconfig from a directory that is higher up than biome.json?

See: #4812 (comment)

@dyc3
Copy link
Contributor

dyc3 commented Feb 16, 2025

As far as I'm aware, no, that case we haven't handled yet.

@arendjr
Copy link
Contributor

arendjr commented Feb 16, 2025

I do think it’s an important one to handle before changing the default, because otherwise it may result in teams having inconsistent formatting experiences if one member has an .editorconfig in their home directory that another member has not.

@fireairforce
Copy link
Member Author

@arendjr yeah, i will do this later, i have seen your comment in the discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Project Area: project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable .editorconfig support by default
3 participants